Fix erroneous recompilations on files with empty but present build/runtest/install/remove field#6505
Merged
kit-ty-kate merged 2 commits intoocaml:masterfrom Oct 16, 2025
Conversation
5d66f41 to
0cadc95
Compare
kit-ty-kate
commented
May 3, 2025
tests/reftests/upgrade.test
Outdated
| ### opam switch create no-recompile --empty | ||
| ### <pkg:ocaml.5> | ||
| opam-version: "2.0" | ||
| ### :WARN: Do NOT use "<pin:...>" for the following line |
Member
Author
There was a problem hiding this comment.
0cadc95 to
4a37e02
Compare
4a37e02 to
3e8d397
Compare
…pty but present build/run-test/install/build field
…ntest/install/remove field
3e8d397 to
0fc26a5
Compare
rjbou
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5814
and partially #6480
See description in #5814 (comment)
Doing so also seems to speedup a couple of actions (see the "Nothing to do" changes in the tests)