Skip to content

Cygwin: Fallback to the existing setup-x86_64.exe if its upgrade failed to be fetched#6482

Merged
kit-ty-kate merged 2 commits intoocaml:masterfrom
kit-ty-kate:cygwin-setupexe-update-no-fail
May 2, 2025
Merged

Cygwin: Fallback to the existing setup-x86_64.exe if its upgrade failed to be fetched#6482
kit-ty-kate merged 2 commits intoocaml:masterfrom
kit-ty-kate:cygwin-setupexe-update-no-fail

Conversation

@kit-ty-kate
Copy link
Copy Markdown
Member

@kit-ty-kate kit-ty-kate commented Apr 23, 2025

Partially f.i.x.e.s #6474
Fix #6495

@kit-ty-kate kit-ty-kate added this to the 2.4.0~alpha2 milestone Apr 23, 2025
@kit-ty-kate kit-ty-kate force-pushed the cygwin-setupexe-update-no-fail branch from d50bf6d to 54068c3 Compare April 23, 2025 13:59
@kit-ty-kate kit-ty-kate requested a review from rjbou April 23, 2025 14:00
@rjbou rjbou linked an issue Apr 29, 2025 that may be closed by this pull request
@kit-ty-kate kit-ty-kate force-pushed the cygwin-setupexe-update-no-fail branch from 54068c3 to 26a2af5 Compare April 29, 2025 16:32
@kit-ty-kate kit-ty-kate requested a review from rjbou April 29, 2025 17:56
Copy link
Copy Markdown
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestion, but absolutely not mandatory.
Thanks!

Comment on lines +285 to +286
Printexc.raise_with_backtrace exn backtrace
)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Printexc.raise_with_backtrace exn backtrace
)
Printexc.raise_with_backtrace exn backtrace)

## Opamfile

## External dependencies
* Cygwin: Fallback to the existing `setup-x86_64.exe` if its upgrade failed to be fetched [#6482 @kit-ty-kate - fix #6495, partial fix #6474]
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Cygwin: Fallback to the existing `setup-x86_64.exe` if its upgrade failed to be fetched [#6482 @kit-ty-kate - fix #6495, partial fix #6474]
* Cygwin: Fallback to the existing `setup-x86_64.exe` if its upgrade failed to be fetched (sha & exe) [#6482 @kit-ty-kate - fix #6495, partial fix #6474]

@kit-ty-kate kit-ty-kate merged commit 9617f42 into ocaml:master May 2, 2025
55 checks passed
@kit-ty-kate kit-ty-kate deleted the cygwin-setupexe-update-no-fail branch May 2, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setup.exe: download failure error instead of retrieving the local exe

2 participants