GHA: Restore the OCaml cache for the Windows jobs#6469
Merged
kit-ty-kate merged 1 commit intoocaml:masterfrom Apr 14, 2025
Merged
GHA: Restore the OCaml cache for the Windows jobs#6469kit-ty-kate merged 1 commit intoocaml:masterfrom
kit-ty-kate merged 1 commit intoocaml:masterfrom
Conversation
rjbou
approved these changes
Apr 14, 2025
dra27
approved these changes
Apr 14, 2025
Member
dra27
left a comment
There was a problem hiding this comment.
LGTM modulo a rebase - the underlying issue seems to be the actions/cache stopped accepting a single file argument in path at some point.
This cache was broken during the switch from ocaml-opam/cache to actions/cache@v4
242c427 to
5e72e96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cache was broken during the switch from
ocaml-opam/cachetoactions/cache@v4in #6081This reduces the time the CI takes by at minimum 8 minutes overall.
Tested successfully on my local fork in kit-ty-kate#12. Both cache creation and restoration work fine.