Only download Cygwin's setup.exe when the command is actually going to be displayed or used#6467
Merged
kit-ty-kate merged 1 commit intoocaml:masterfrom Apr 9, 2025
Conversation
Collaborator
|
I think its better to move those check directly in opam/src/state/opamSysInteract.ml Lines 1047 to 1051 in 1458aa7 |
Member
Author
|
This is orthogonal to this PR though. Could we first deal with the CI failures and improve internals later? If you're fine with that please feel free to open a ticket so we can remember to do it |
4c1ad9d to
91f83fa
Compare
91f83fa to
562aab3
Compare
…o be displayed or used
562aab3 to
8a44523
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opam only look at
os-distributionto know if it should download Cygwin'ssetup.exeor not:opam/src/client/opamSolution.ml
Line 1222 in 1458aa7
opam/src/client/opamSolution.ml
Line 1254 in 1458aa7
The tests have been failing quite frequently over the past two days due to some network issues with
cygwin.com. Settingos-distributionto not becygwinshould alleviate this.