Closed
Conversation
Contributor
|
Note that the idea of #6425 was to simply suppress unabstract uses of converter and make it compile with 1.3.0 without deprecation warnings to allow for a smooth eco-system transition. This uses 2.0.0 APIs. Regarding the introduction of a global reference the answer is still no: global references are not compositional. The last thing I want to see is libraries fighting to set that value or change it behind user's back. |
Member
Author
|
Superseded by #6755 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6425
Issues to address:
CMDLINER_LEGACY_PREFIXES=trueescape hatch. I would much rather have a global reference (e.g. kit-ty-kate/cmdliner@94ecc8a) or whatever to make sure the behaviour doesn't change between two versions while we weren't looking?envdoesn't work withArg.enum. Using the example patch above, this issue would be fixed.If we decide to fork cmdliner with the following patch above master kit-ty-kate/cmdliner@1565763, those issues wouldn't be there anymore at the cost of extra maintenance.
cc @dbuenzli