Skip to content

lock: add '--keep-local' argument to add local pins to 'pin-depends:' field#6411

Merged
kit-ty-kate merged 2 commits intoocaml:masterfrom
rjbou:lock-local-pins
Mar 7, 2025
Merged

lock: add '--keep-local' argument to add local pins to 'pin-depends:' field#6411
kit-ty-kate merged 2 commits intoocaml:masterfrom
rjbou:lock-local-pins

Conversation

@rjbou
Copy link
Copy Markdown
Collaborator

@rjbou rjbou commented Mar 6, 2025

fix #4897

@kit-ty-kate
Copy link
Copy Markdown
Member

I pushed two fixup commits fixing my comments. What do you think?

@rjbou rjbou force-pushed the lock-local-pins branch from 891fe0a to a39bf90 Compare March 7, 2025 16:11
@rjbou rjbou requested a review from kit-ty-kate March 7, 2025 16:12
@rjbou rjbou force-pushed the lock-local-pins branch from a39bf90 to da172f4 Compare March 7, 2025 16:13
@rjbou
Copy link
Copy Markdown
Collaborator Author

rjbou commented Mar 7, 2025

Good for me the changes. I updated the doc & manpage accordingly.

Copy link
Copy Markdown
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@kit-ty-kate
Copy link
Copy Markdown
Member

Thanks!

@kit-ty-kate kit-ty-kate merged commit f1cf50f into ocaml:master Mar 7, 2025
43 checks passed
@kit-ty-kate kit-ty-kate linked an issue Mar 10, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

opam lock ignores pin-depends Add a flag to opam lock to keep local pins

2 participants