opam admin: enforce repository root check for all commands and add upgrade advice#6391
Merged
kit-ty-kate merged 4 commits intoocaml:masterfrom Oct 16, 2025
Merged
Conversation
00c4035 to
799f8b1
Compare
kit-ty-kate
reviewed
Feb 20, 2025
| match repo_version_lt repo_root | ||
| (OpamVersion.of_string default_current) with | ||
| | Some v -> | ||
| OpamConsole.warning |
Member
There was a problem hiding this comment.
I think opam admin should simply refuse to handle 1.2 repositories
Suggested change
| OpamConsole.warning | |
| OpamConsole.error_and_exit |
Collaborator
Author
There was a problem hiding this comment.
It can be done that way too. It need a proper cleaning of the code if there is some that handles 1.2 backward compatibility (expect upgrade ofc).
799f8b1 to
7fb6afa
Compare
kit-ty-kate
reviewed
Aug 26, 2025
Member
kit-ty-kate
left a comment
There was a problem hiding this comment.
Looks good though I have some suggestions below.
I'm also wondering if we could move the test commit to be the first one of this PR to also see the result of the first commit
7fb6afa to
49e509b
Compare
kit-ty-kate
reviewed
Oct 16, 2025
Member
kit-ty-kate
left a comment
There was a problem hiding this comment.
aside from this minor change, lgtm
49e509b to
fec0531
Compare
kit-ty-kate
approved these changes
Oct 16, 2025
fec0531 to
ea51cdc
Compare
Member
|
ocaml-benchmarks failed due to a lack of disk space on the test machine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.