Do not pre-write the answer to questions with the default anwser#6376
Merged
kit-ty-kate merged 2 commits intoocaml:masterfrom Feb 10, 2025
Merged
Do not pre-write the answer to questions with the default anwser#6376kit-ty-kate merged 2 commits intoocaml:masterfrom
kit-ty-kate merged 2 commits intoocaml:masterfrom
Conversation
57cf486 to
ac627d0
Compare
ac627d0 to
125f74c
Compare
125f74c to
157c7cf
Compare
rjbou
approved these changes
Feb 5, 2025
Collaborator
rjbou
left a comment
There was a problem hiding this comment.
On the code itself, lgtm!
The commit should be split in 2 commits
Member
Author
why? I don't think this is reasonable without introducing new bugs in between the two commits |
157c7cf to
6e89c8c
Compare
Member
Author
sorry nevermind, i was thinking of something else. Done. |
rjbou
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #6290
This implements #6289 (review)