Stop double pin of packages located in ./opam/opam#6343
Merged
kit-ty-kate merged 3 commits intoocaml:masterfrom Jan 16, 2025
Merged
Stop double pin of packages located in ./opam/opam#6343kit-ty-kate merged 3 commits intoocaml:masterfrom
kit-ty-kate merged 3 commits intoocaml:masterfrom
Conversation
b6a6178 to
72a5879
Compare
rjbou
approved these changes
Jan 15, 2025
Collaborator
rjbou
left a comment
There was a problem hiding this comment.
I've added a test in pin test (lock test is a side effect, it's not its purpose).
Otherwise, lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6342
The problem was that the
files_in_sourcefunction would call its internal scanning functionfilestwice on<dir>and<dir>/opam, however a side close of that subfunction would itself add<dir>/opam/opamif it is detected, which leads to the same file being detected twice.