sandbox: respect the DUNE_CACHE_ROOT environment variable if it exists#6326
Merged
kit-ty-kate merged 1 commit intoocaml:masterfrom Dec 6, 2024
Merged
Conversation
52576ac to
7423bf4
Compare
7423bf4 to
392dbc4
Compare
Signed-off-by: Sora Morimoto <sora@morimoto.io>
392dbc4 to
400b2f6
Compare
kit-ty-kate
approved these changes
Dec 6, 2024
Member
kit-ty-kate
left a comment
There was a problem hiding this comment.
the bubblewrap (linux) sandbox script also needed to be changed but i've done it. lgtm
Member
Author
|
Thanks a lot! |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users can set
DUNE_CACHE_ROOT, which has a higher priority than other environment variables.Currently, there are some cases where the cache functionality does not work well when
DUNE_CACHE_ROOTis set.Ref: https://dune.readthedocs.io/en/stable/caching.html