lint: add W74 to detect 'pin-depends' packages that are not present in 'depends' nor in 'depopts'#6317
Merged
kit-ty-kate merged 1 commit intoocaml:masterfrom Feb 22, 2025
Merged
Conversation
kit-ty-kate
previously approved these changes
Nov 28, 2024
kit-ty-kate
reviewed
Nov 28, 2024
kit-ty-kate
reviewed
Nov 28, 2024
20cbb73 to
186ab9a
Compare
186ab9a to
aed41b2
Compare
kit-ty-kate
reviewed
Dec 3, 2024
Member
kit-ty-kate
left a comment
There was a problem hiding this comment.
The code can be improved by eliminating 3 out of the 6 datatypes traverses.
The gain is small in this particular case but out of principle it feels weird to not do better if the code is as short and maybe even more understandable
Collaborator
Author
|
I find the set transformation by pipe more human understandable (you just follow the function name, not read the code of the function given to fold). But agree on the optim part. |
aed41b2 to
e44a5f6
Compare
…n 'depends' nor in 'depopts'
e44a5f6 to
19c5b9d
Compare
kit-ty-kate
approved these changes
Feb 22, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #5795
This lint doesn't detect when the versions mismatch.