Run shellcheck on shell/install.sh and make it pass, add a CI job to check next changes#6313
Merged
kit-ty-kate merged 2 commits intoocaml:masterfrom Dec 2, 2024
Merged
Conversation
Contributor
|
Nice to see this going forward! |
rjbou
reviewed
Nov 28, 2024
Collaborator
rjbou
left a comment
There was a problem hiding this comment.
On the content, lgtm! It's better to split on 2 commits: the first that updates shell/install.sh and the other that adds the CI check and confirms it passes.
Plus the PR title/comments should highlight the new shellcheck CI check.
de764d4 to
1e2f399
Compare
Co-authored-by: Ambre Austen Suhamy <ambre@tarides.com>
1e2f399 to
1004840
Compare
rjbou
approved these changes
Dec 2, 2024
Collaborator
rjbou
left a comment
There was a problem hiding this comment.
I've added an entry for the first commit in changelog. Otherwise, LGTM!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a partial subset of #5778.
This PR is meant as a way to more easily kickstart the use of shellcheck to lint checkout shell scripts.
Details of reason behind the shell changes:
$()vs backtickslocal$@in stringsreadwithout-rwill interpret backslashesprintfcould contain%which could make the command failThis PR also make sure the script keeps passing
shellcheckby adding it to our CI.