Don't ask confirmation when pinning a new package#6309
Merged
rjbou merged 1 commit intoocaml:masterfrom Feb 5, 2025
Merged
Conversation
258058d to
f73569b
Compare
rjbou
reviewed
Nov 25, 2024
Collaborator
|
Discussion on dev meeting: We agree that the question is too much, but the information remains relevant as it may indicate that a repository is missing or that the package name is mistyped. |
f73569b to
63bdee5
Compare
kit-ty-kate
commented
Nov 30, 2024
582e6b2 to
9e214de
Compare
Co-authored-by: R. Boujbel <rjbou@ocamlpro.com>
9e214de to
008f8af
Compare
rjbou
approved these changes
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3199
While reading #3199 i asked myself why this question was asked and i couldn't find any reason. It was added in #1335 with no reasoning behind it either.
In my opinion the question is redundant as the user is already asking to pin the package(s).