Skip to content

Fix the detection of ZDOTDIR when using zsh#6299

Merged
kit-ty-kate merged 1 commit intoocaml:masterfrom
acasta-yhliu:master
Nov 15, 2024
Merged

Fix the detection of ZDOTDIR when using zsh#6299
kit-ty-kate merged 1 commit intoocaml:masterfrom
acasta-yhliu:master

Conversation

@acasta-yhliu
Copy link
Copy Markdown
Contributor

@acasta-yhliu acasta-yhliu commented Nov 15, 2024

As mentioned in #6281, ZDOTDIR is not checked when modifying env by opam init. Detection is added to src/core/openStd.ml

Fixes #6281

Copy link
Copy Markdown
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kit-ty-kate kit-ty-kate changed the title Fixed #6281, ZDOTDIR is awared by opam in now Fix the detection of ZDOTDIR when using zsh Nov 15, 2024
Copy link
Copy Markdown
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@kit-ty-kate
Copy link
Copy Markdown
Member

Thanks a lot!

@kit-ty-kate kit-ty-kate merged commit e687af0 into ocaml:master Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ZDOTDIR value not checked,

3 participants