Use an uppercase character again for the default in interactive questions#6289
Merged
rjbou merged 1 commit intoocaml:masterfrom Nov 14, 2024
Merged
Use an uppercase character again for the default in interactive questions#6289rjbou merged 1 commit intoocaml:masterfrom
rjbou merged 1 commit intoocaml:masterfrom
Conversation
kit-ty-kate
approved these changes
Nov 11, 2024
Member
kit-ty-kate
left a comment
There was a problem hiding this comment.
I'm all for this change. It fits with my ignored opinion in #5053 (comment) except for the <no character> part which requires some further changes which can be done separately if we want (i'll open a PR anyway, it's linked to a small bug i noticed), but i don't care as much about that as the standard unix [Y/n] question style
Member
Author
|
Thanks for the reftest fixes! Happy that there's an approval. |
rjbou
approved these changes
Nov 13, 2024
Collaborator
|
Discussed on dev meeting: we all agree and welcome that change, thanks! |
…ions Fix ocaml#6288 Co-authored-by: Kate <kit-ty-kate@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #6288
Please update
master_changes.mdfile with your changes.