Remove linked switches without failing#6276
Merged
kit-ty-kate merged 2 commits intoocaml:masterfrom Nov 14, 2024
Merged
Conversation
66d5fc8 to
b39d97d
Compare
rjbou
reviewed
Oct 29, 2024
Collaborator
rjbou
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I've updated the test (split the commit into before/after), and updated changes too.
I kept a commit as fixup commit to propose an alternative implementation, in order to factorise the check done in remove_dir_t and remove_dir.
kit-ty-kate
approved these changes
Oct 29, 2024
rjbou
approved these changes
Nov 12, 2024
b39d97d to
bc09e4a
Compare
Fix OpamSystem.remove_dir to not fail when directory is a symbolic link. Co-authored-by: Raja Boujbel <raja.boujbel@ocamlpro.com>
bc09e4a to
5c28606
Compare
Member
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed fix and reproduction test for #6275