opam upgrade: Do not show the not-up-to-date message with packages tagged with avoid-version#6273
Conversation
7da8317 to
f810b2a
Compare
| let name = OpamPackage.name pkg in | ||
| let pkgs = OpamPackage.packages_of_name t.packages name in | ||
| let latest = | ||
| OpamPackage.Set.fold (fun pkg latest -> |
There was a problem hiding this comment.
this variable named pkg and the one defined 4 lines above are not the "same package" but have the same name, this can be misleading when reading the code.
There was a problem hiding this comment.
I disagree. Since the name above doesn't have any use below i think it's better to shadow it. The same pattern is used in different places in our code already and i think it make sense to use it here
There was a problem hiding this comment.
The same pattern is used true, usually it is a map that is populated through intertwined fold, and in that case it is more clear. But i'm sure that we can find this pattern for other case :)
| (OpamPackage.names_of_packages to_check) | ||
| OpamPackage.Set.fold (fun pkg acc -> | ||
| let name = OpamPackage.name pkg in | ||
| let pkgs = OpamPackage.packages_of_name t.packages name in |
There was a problem hiding this comment.
I don't know if it worth working on the set of version instead of package one.
There was a problem hiding this comment.
it simplifies the code greatly. Otherwise we would need to have an intermediate map of set and update it
f810b2a to
9aa898b
Compare
9aa898b to
3c9bdb2
Compare
…d with avoid-version/deprecated
…gged with avoid-version
3c9bdb2 to
8360db5
Compare
Fixes #6271