Improve the messages when a package is not up-to-date on opam upgrade#6272
Merged
rjbou merged 1 commit intoocaml:masterfrom Oct 30, 2024
Merged
Conversation
f624b0b to
eca8fcd
Compare
rjbou
reviewed
Oct 29, 2024
Collaborator
rjbou
left a comment
There was a problem hiding this comment.
It's missing test update, otherwise, lgtm!
| OpamConsole.formatted_msg | ||
| "However, you may \"opam upgrade\" these packages explicitly, \ | ||
| "However, you may \"opam upgrade\" these packages explicitly \ | ||
| at these versions (e.g. \"opam upgrade %s\"), \ |
Collaborator
There was a problem hiding this comment.
Suggested change
| at these versions (e.g. \"opam upgrade %s\"), \ | |
| at these versions (e.g. 'opam upgrade %s'), \ |
+ some underline ?
Member
Author
There was a problem hiding this comment.
the single quotes clashes with the double-quotes used prior in the same sentense. I think it's better to stay consistent
Member
Author
There was a problem hiding this comment.
for underline, i'm not sure if it's necessary. The rest of the opam example commands in our codebase uses either double-quotes like here or bold, the former being used more often.
Collaborator
There was a problem hiding this comment.
They are both used in fact, " and '.
eca8fcd to
e721c73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6270 and also the confusing message about
--verbosewhen it is unnecessary.