Ensure the right versions of packages are used when simulating pinning#6256
Merged
kit-ty-kate merged 2 commits intoocaml:masterfrom Mar 13, 2025
Merged
Conversation
7f616a2 to
724ac4c
Compare
724ac4c to
4bef915
Compare
This was
linked to
issues
Feb 25, 2025
4bef915 to
5a93cc3
Compare
5a93cc3 to
f9bdd4f
Compare
f9bdd4f to
0e0eb5f
Compare
0e0eb5f to
31218de
Compare
rjbou
approved these changes
Mar 13, 2025
Collaborator
rjbou
left a comment
There was a problem hiding this comment.
Tiny comments, otherwise lgtm!
Co-authored-by: Kate <kit-ty-kate@outlook.com>
736eed5 to
32357c4
Compare
Collaborator
|
I've updated the main comment |
rjbou
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Force the version constraint on requested package when a simulate pin is done.
See explanation in #6379 (comment)
Fixes #6379
Fixes #6248
This PR is queued on top of #6209The current title is temporary while i'm trying to understand what is the cause of the bugI'm really confused as to what is making the made-up test work just fine but the test with goblint fail.I'd like to understand what is making opam get almost all the dependencies but missppx_blobin the first deps-only install.Ideally once we understand what's happening we should be able to build a dedicated test and remove the one relying on opam-repository