Lookup at gpatch before patch on macOS now that both homebrew and macports expose gpatch as gpatch#6255
Merged
kit-ty-kate merged 2 commits intoocaml:masterfrom Dec 17, 2024
Merged
Conversation
9d0e84f to
7c1d171
Compare
b3ed73c to
284b807
Compare
rjbou
approved these changes
Dec 17, 2024
…ports expose gpatch as gpatch Homebrew changed behaviour in Homebrew/homebrew-core#174687
284b807 to
0f352f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homebrew changed behaviour in Homebrew/homebrew-core#174687
This is only an optimization (avoids the (probably) unnecessarypatch --version), this doesn't change the general behaviour at all.EDIT: actually nevermind, this changes the behaviour in case, neither
patchorgpatchare available and GNU patch. In that case, it would default to usepatch, but now it will usegpatchby default. Which means that if someone hasn't installed gpatch, previously it would show a warning and usedpatchanyway, but now it will show a warning and fail to executegpatch.