Change example of non-letter in version ordering#6252
Merged
kit-ty-kate merged 2 commits intoocaml:masterfrom Oct 21, 2024
Merged
Change example of non-letter in version ordering#6252kit-ty-kate merged 2 commits intoocaml:masterfrom
kit-ty-kate merged 2 commits intoocaml:masterfrom
Conversation
1eaf91e to
1ed6527
Compare
1ed6527 to
5efcc15
Compare
The "Package Formulas" grammar in the manual says that valid characters for version numbers are `<identchar> | "+" | "." | "~"`. Notably this does not include the "#" character. This change updates the example of a comparing a letter to a non-letter character to use a non-letter character that may appear in a version number. Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
5efcc15 to
a3c6ec9
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Package Formulas" grammar in the manual says that valid characters for version numbers are
<identchar> | "+" | "." | "~". Notably this does not include the "#" character. This change updates the example of a comparing a letter to a non-letter character to use a non-letter character that may appear in a version number.Please update
master_changes.mdfile with your changes.