[2.3 backport] System polling: Harden the process calls to account for failure#6228
Merged
kit-ty-kate merged 1 commit intoocaml:2.3from Oct 9, 2024
Merged
Conversation
This was referenced Oct 7, 2024
212e1fb to
b568fd0
Compare
…Harden the process calls to account for failure with_process_in was fairly brittle and would display stderr by default and ignore errors. The new version of that function (renamed process_in) now uses Unix.open_process_full and returns None if anything went wrong, fixing the issue on OpenBSD where `getconf LONG_BIT` would fail.
3c9cad9 to
19246ac
Compare
rjbou
approved these changes
Oct 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with_process_inwas fairly brittle and would display stderr by default and ignore errors. The new version of that function (renamedprocess_in) now usesUnix.open_process_fulland returns None if anything went wrong, fixing the issue on OpenBSD wheregetconf LONG_BITwould fail (End_of_file wasn't handled)Backports #6230 to 2.3