[2.3 backport] Fix the compilation of opam on Windows with OCaml >= 5.0 (again)#6224
Merged
kit-ty-kate merged 5 commits intoocaml:2.3from Oct 9, 2024
Merged
Conversation
This was referenced Oct 2, 2024
f1aa773 to
5940e7d
Compare
…t more than one default version
Windows is an exception since MSVC isn't supported yet (will be in 5.3.0), and Cygwin fails when used in combination with C++ stubs. So only MinGW x86_64 is tested because it's the only one that both works and is reasonably fast to run (i686 is too slow since it's using bytecode).
…upported by master This marginally increases build time (by 30s best case scenario) but is a necessary fix
5940e7d to
f054de8
Compare
rjbou
approved these changes
Oct 9, 2024
Collaborator
|
I've rebased and synchronised it with #6216 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #6216 to 2.3
Queued on #6225