Add 2 admin commands to compare 2 package versions#6196
Closed
mbarbin wants to merge 1 commit intoocaml:masterfrom
Closed
Add 2 admin commands to compare 2 package versions#6196mbarbin wants to merge 1 commit intoocaml:masterfrom
mbarbin wants to merge 1 commit intoocaml:masterfrom
Conversation
1 task
696a4fc to
39866fc
Compare
This is meant for quick sanity checks for example. - Added some basic tests to cover the commands. Signed-off-by: Mathieu Barbin <mathieu.barbin@gmail.com>
39866fc to
28bff74
Compare
Contributor
Author
|
Will go with #6197 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 2 new commands
opam admin {assert-}compare-versionsto compare package versions for sanity checks.compare-versions- User interactive.In this command, we provide two versions, and opam outputs a user-friendly expression with the result of the comparison, spelled out. For example:
$ opam admin compare-versions 0.0.9 0.0.10 0.0.9 < 0.0.10The command exits 0 regardless of the result of the comparison.
assert-compare-versions- For use in scripts, if needed.This command is silent, and requires an operator {lt,le,eq}. The result of the command will be encoded in the exit code, to be used in bash conditionals:
exit 0: the comparison holds
exit 1: it doesn't
For example:
This PR is an alternative to #6124 trying to account for the various feedback received.