Skip to content

Fix opam switch list-available pkg.version pattern#6186

Merged
kit-ty-kate merged 2 commits intoocaml:masterfrom
arozovyk:list_available_pkg.version_pat
Dec 3, 2024
Merged

Fix opam switch list-available pkg.version pattern#6186
kit-ty-kate merged 2 commits intoocaml:masterfrom
arozovyk:list_available_pkg.version_pat

Conversation

@arozovyk
Copy link
Copy Markdown
Collaborator

@arozovyk arozovyk commented Sep 2, 2024 •
edited by kit-ty-kate
Loading

Adresses #6152
Queued on #6318

@arozovyk arozovyk force-pushed the list_available_pkg.version_pat branch 2 times, most recently from 1538737 to 32b9d00 Compare September 2, 2024 10:15
@arozovyk arozovyk marked this pull request as ready for review September 2, 2024 10:22
@kit-ty-kate kit-ty-kate requested a review from rjbou September 2, 2024 14:23
@kit-ty-kate kit-ty-kate added this to the 2.4.0~alpha1 milestone Sep 25, 2024
@rjbou rjbou force-pushed the list_available_pkg.version_pat branch from 7c83981 to 4a5dc46 Compare October 30, 2024 16:34
@rjbou rjbou requested a review from kit-ty-kate October 30, 2024 16:35
rjbou
rjbou approved these changes Oct 30, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! As we discussed, I've reworked the change.

kit-ty-kate
kit-ty-kate requested changes Oct 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure ands made sense in general in the first place. I think we should change the behaviour to use ors instead.
Otherwise there is no use to allow several parameters. e.g.

$ opam switch list-available ocaml-base-compiler ocaml-variants
# Listing available compilers from repositories: kit-ty-kate, default
# No matches found

If we switch to ors instead we can also simply remove the addition of the ?concat, which doesn't seem useful to me.

Ideally we should also have a test showing the behaviour of list-available with several parameters

@rjbou
Copy link
Copy Markdown
Collaborator

rjbou commented Nov 29, 2024

If we switch from ands to ors, it is the purpose of another PR.

@kit-ty-kate kit-ty-kate mentioned this pull request Nov 30, 2024
Merged
@kit-ty-kate kit-ty-kate added the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Nov 30, 2024
@kit-ty-kate
Copy link
Copy Markdown
Member

kit-ty-kate commented Nov 30, 2024

If we switch from ands to ors, it is the purpose of another PR.

Done in #6318. This should be merged first. I've marked this here PR as queued on it.

@kit-ty-kate kit-ty-kate changed the title Fix opam switch list-available pkg.version patttern Fix opam switch list-available pkg.version pattern Nov 30, 2024
@kit-ty-kate kit-ty-kate force-pushed the list_available_pkg.version_pat branch from 4a5dc46 to e45202e Compare November 30, 2024 23:47
@kit-ty-kate
Copy link
Copy Markdown
Member

kit-ty-kate commented Nov 30, 2024

rebased

@kit-ty-kate kit-ty-kate force-pushed the list_available_pkg.version_pat branch from e45202e to 06b9efd Compare November 30, 2024 23:56
@kit-ty-kate
Copy link
Copy Markdown
Member

kit-ty-kate commented Nov 30, 2024

new proposal queued on top of #6318 with one extra test

@rjbou rjbou force-pushed the list_available_pkg.version_pat branch from 06b9efd to 69a1fc5 Compare December 3, 2024 16:32
@rjbou rjbou added STATE: READY TO MERGE and removed PR: QUEUED Pending pull request, waiting for other work to be merged or closed labels Dec 3, 2024
@kit-ty-kate
Copy link
Copy Markdown
Member

kit-ty-kate commented Dec 3, 2024

Thanks!

@kit-ty-kate kit-ty-kate merged commit 8a38781 into ocaml:master Dec 3, 2024
@rjbou rjbou mentioned this pull request Feb 28, 2025
Closed
@kit-ty-kate kit-ty-kate linked an issue Mar 1, 2025 that may be closed by this pull request
opam switch list-available doesn't handle pkg.version pattern #6152
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kit-ty-kate kit-ty-kate kit-ty-kate approved these changes

@rjbou rjbou rjbou approved these changes

Assignees

No one assigned

Labels

AREA: UI

Projects

None yet

Milestone

2.4.0~alpha1

Development

Successfully merging this pull request may close these issues.

opam switch list-available doesn't handle pkg.version pattern

3 participants

@arozovyk @rjbou @kit-ty-kate