Fail when a git submodule fails to update instead of ignoring the error#6132
Merged
kit-ty-kate merged 3 commits intoocaml:masterfrom Aug 20, 2024
Merged
Fail when a git submodule fails to update instead of ignoring the error#6132kit-ty-kate merged 3 commits intoocaml:masterfrom
kit-ty-kate merged 3 commits intoocaml:masterfrom
Conversation
cab43a1 to
ed71ca0
Compare
dra27
reviewed
Aug 5, 2024
rjbou
requested changes
Aug 8, 2024
Collaborator
rjbou
left a comment
There was a problem hiding this comment.
On the code itself, lgtm!
Some remarks:
- The title of the PR doesn't fit the content, the second commit it more submodules handling than the failure itself. It needs to be updated by something more general, like "git submodules enhancements".
- Add a test to highlight the modifications, and follow them
100c9d6 to
c459fbd
Compare
2 tasks
Member
Author
|
I've split off the second commit in #6153 and added a test |
bffc94f to
2a1e199
Compare
2a1e199 to
1d034d0
Compare
1d034d0 to
d442c01
Compare
rjbou
reviewed
Aug 20, 2024
Comment on lines
+12
to
+14
| ### ### This test may fail locally depending on your git version | ||
| ### ### File protocol is removed locally since git 2.38, | ||
| ### ### to fix a CVE: https://www.cve.org/CVERecord?id=CVE-2022-39253 |
Member
Author
There was a problem hiding this comment.
That note isn't quite true. Only a couple of versions have file protocol disabled. More recent git versions work just fine
Member
Author
There was a problem hiding this comment.
Ah nevermind, what i'm saying is not true. My memory failed me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6131