Closed
Conversation
This is meant for quick sanity checks for example. - Added some basic tests to cover the command. The tests I added do not duplicate the tests for the actual comparison function, rather that meant to cover the basic cases encountered by the command. Signed-off-by: Mathieu Barbin <mathieu.barbin@gmail.com>
- Update test trace Signed-off-by: Mathieu Barbin <mathieu.barbin@gmail.com>
Signed-off-by: Mathieu Barbin <mathieu.barbin@gmail.com>
Signed-off-by: Mathieu Barbin <mathieu.barbin@gmail.com>
Signed-off-by: Mathieu Barbin <mathieu.barbin@gmail.com>
1 task
Member
|
This looks good to me! |
Contributor
Author
|
Great! @kit-ty-kate if you give it your thumbs-up I'll push these commits to the original PR, as new ground for a next pass of edits/review. Thanks! |
Member
|
@mbarbin sure, i don't mind either version |
Contributor
Author
|
Hello @kit-ty-kate - Thank you, I added these commits plus some more tweaks to the original PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is exploring a tweak to #6124 with an optional flag to control the command exit code.
This is pushed a separate draft just for reference during the conversation.