Fix macos sandbox script incorrectly assuming that getconf doesn't exist#5780
Merged
dra27 merged 1 commit intoocaml:masterfrom Jan 22, 2024
Merged
Fix macos sandbox script incorrectly assuming that getconf doesn't exist#5780dra27 merged 1 commit intoocaml:masterfrom
getconf doesn't exist#5780dra27 merged 1 commit intoocaml:masterfrom
Conversation
kit-ty-kate
reviewed
Jan 12, 2024
Member
kit-ty-kate
left a comment
There was a problem hiding this comment.
Note that by default macOS already defines TMPDIR during startup so this code is almost never executed in practice (i think the only way would be if you manually unset that variable or if you start your shell with env -i, which is definetely possible but unlikely)
3c516ee to
3dd6fca
Compare
kit-ty-kate
approved these changes
Jan 12, 2024
3dd6fca to
a0960d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #5778, this is a proper bugfix:
[ -z /usr/bin/getconf ]tests if the literal string "/usr/bin/getconf" is empty - which is always false - and doesn't probe the filesystem at all.command -v getconf >/dev/nullactually asks the system if that command exists. The place where it is defined (/usr/bin or anything else) doesn't matter since we call it directly below.It should be noted that if
$TMPDIRis not set andgetconfdoesn't exist, we carry on the program silently. Is that intended?I do not have a macos machine on hand and cannot test this, but this could be related to #4958