Skip to content

Fix the sandbox scripts in absence of the OPAMROOT variable#5662

Merged
kit-ty-kate merged 1 commit intoocaml:masterfrom
kit-ty-kate:fix-sandbox
Sep 11, 2023
Merged

Fix the sandbox scripts in absence of the OPAMROOT variable#5662
kit-ty-kate merged 1 commit intoocaml:masterfrom
kit-ty-kate:fix-sandbox

Conversation

@kit-ty-kate
Copy link
Copy Markdown
Member

@kit-ty-kate kit-ty-kate commented Sep 11, 2023 •
edited
Loading

Bug I introduced by error in #5634

/home/kit_ty_kate/.opam/opam-init/hooks/sandbox.sh contains local modification, overwrite ? [y/n] y
[ERROR] Sandboxing is not working on your platform archarm:
        "~/.opam/opam-init/hooks/sandbox.sh build sh -c echo SUCCESS | tee check-write" exited with code 1 "/home/kit_ty_kate/.opam/opam-init/hooks/sandbox.sh: line 105: OPAMROOT: unbound variable"

@kit-ty-kate kit-ty-kate added this to the 2.2.0~alpha3 milestone Sep 11, 2023
@kit-ty-kate
Copy link
Copy Markdown
Member Author

kit-ty-kate commented Sep 11, 2023

Merged without waiting for CI to finish to avoid breaking users of the master branch. We'll look into adding a test for the sandbox with an absent OPAMROOT variable in a subsequent PR soon.

@kit-ty-kate kit-ty-kate merged commit 7f949f3 into ocaml:master Sep 11, 2023
@kit-ty-kate kit-ty-kate deleted the fix-sandbox branch September 11, 2023 16:15
@kit-ty-kate kit-ty-kate mentioned this pull request Sep 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjbou rjbou rjbou approved these changes

Assignees

No one assigned

Labels

KIND: BUG PRIORITY

Projects

None yet

Milestone

2.2.0~alpha3

Development

Successfully merging this pull request may close these issues.

2 participants

@kit-ty-kate @rjbou