Skip to content

reftests: add test for operators in opamfile filters#5642

Merged
kit-ty-kate merged 1 commit intoocaml:masterfrom
rjbou:test-filter-operators
Jul 9, 2024
Merged

reftests: add test for operators in opamfile filters#5642
kit-ty-kate merged 1 commit intoocaml:masterfrom
rjbou:test-filter-operators

Conversation

@rjbou
Copy link
Copy Markdown
Collaborator

@rjbou rjbou commented Aug 24, 2023

No description provided.

@rjbou rjbou force-pushed the test-filter-operators branch from 4fc119c to 8462183 Compare August 24, 2023 15:59
@rjbou rjbou force-pushed the test-filter-operators branch from 8462183 to 6d32dc6 Compare September 5, 2023 14:01
@rjbou rjbou force-pushed the test-filter-operators branch from dfe6255 to 1798862 Compare September 13, 2023 21:26
@rjbou rjbou force-pushed the test-filter-operators branch from 1798862 to 364f9c6 Compare December 12, 2023 10:15
@rjbou rjbou force-pushed the test-filter-operators branch from 364f9c6 to f50596c Compare April 9, 2024 17:15
@rjbou rjbou requested review from dra27 and kit-ty-kate May 3, 2024 08:50
@kit-ty-kate kit-ty-kate removed their request for review May 9, 2024 13:24
- install c 1 [required by gteq]
- install gteq 1
- install ok 1 [required by gteq]
### :: Combination ::
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's definitely good to have some tests for this, but I'm not sure that reftests are the correct harness? Wouldn't it be better to be testing the filter parser then evaluation of filters separately (alcotest-style or some such), rather than invoking the whole of opam machinery to test this?

I'm pretty sure the tests above this comment would definitely be clearer as a standard test case harness and I'm fairly even the tests below would be?

(i.e. I think the reftests framework is excellent for full-blown tests, but these feel more like unit tests and the framework's overkill for that?)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to have in the reftest since it's something that is usable and most used from the command line tool

@kit-ty-kate
Copy link
Copy Markdown
Member

Thanks!

@kit-ty-kate kit-ty-kate merged commit 07300ae into ocaml:master Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants