lock: fix pin-depends with with- variables#5471
Merged
rjbou merged 2 commits intoocaml:masterfrom Feb 21, 2025
Merged
Conversation
a7bfbc8 to
df6abe6
Compare
df6abe6 to
84a75d6
Compare
84a75d6 to
a56c1e5
Compare
kit-ty-kate
reviewed
Nov 22, 2024
Member
kit-ty-kate
left a comment
There was a problem hiding this comment.
lgtm apart from this small suggestion
| ### opam lock tolock | ||
| Generated lock files for: | ||
| - tolock.dev: ${BASEDIR}/tolock.opam.locked | ||
| ### opam-cat tolock.opam.locked |
Member
There was a problem hiding this comment.
cat would be way more readable
Suggested change
| ### opam-cat tolock.opam.locked | |
| ### cat tolock.opam.locked |
Collaborator
Author
There was a problem hiding this comment.
opam-cat is used to avoid having the test change in case the format/padding on an opam file printer changes, the order of fields, etc. It's a reproducible way to print opam file in reftest when we care only about the content.
kit-ty-kate
reviewed
Nov 22, 2024
ef0ac75 to
c6afba3
Compare
kit-ty-kate
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #5428