Skip to content

opamSpdxList: add LGPL-3.0 linking exception#4747

Closed
mseri wants to merge 3 commits intoocaml:masterfrom
mseri:patch-1
Closed

opamSpdxList: add LGPL-3.0 linking exception#4747
mseri wants to merge 3 commits intoocaml:masterfrom
mseri:patch-1

Conversation

@mseri
Copy link
Copy Markdown
Member

@mseri mseri commented Jul 8, 2021

Seen on ocaml/opam-repository#19010

  • Update master_changes.md file with your changes.

@dra27
Copy link
Copy Markdown
Member

dra27 commented Jul 19, 2021

Given the relevance to OCaml, I wonder if it's worth taking this opportunity to add a lint warning (or even error) when the exception and licence combination is invalid (cf. ocaml/opam-repository#19010 (comment)).

opam-repository features these uses of OCaml-LGPL-linking-exception:
LGPL-2.0-only WITH OCaml-LGPL-linking-exception
LGPL-2.1-only WITH OCaml-LGPL-linking-exception
LGPL-2.1-or-later WITH OCaml-LGPL-linking-exception
LGPL-2.1 WITH OCaml-LGPL-linking-exception
LGPL-3.0-only WITH OCaml-LGPL-linking-exception
LGPL-3.0-or-later WITH OCaml-LGPL-linking-exception

The exception has existed with both GNU Library GPL v2.0 and GNU Lesser GPL v2.1 (clause 2 is identical in both and, although I'm not lawyer, clause 6 does not look materially different), so I think the LPGL-2.0-only, LGPL-2.1-only and LGPL 2.1 uses are clearly valid.

With even more emphasis on not being a lawyer, I would assume that LGPL-2.1-or-later requires a legal common-sense application of the exception to LPGL 3.0 (i.e. the fact that the clause numberings are different does not invalidate the intent of the exception).

However, that's quite clearly not the case for LGPL-3.0-only and LGPL-3.0-or-later so it would be a good service to the community if we rejected them!

"GCC-exception-2.0";
"mif-exception";
"OCaml-LGPL-linking-exception";
"LGPL-3.0-linking-exception";
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is autogenerated so this isn't quite the right fix (there is a comment in the dune file)
However #4768 should fix that for good hopefully.

@kit-ty-kate
Copy link
Copy Markdown
Member

Superseded by #4768. Thanks though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants