Conversation
AltGr
left a comment
There was a problem hiding this comment.
Thanks! Some concerns about the generality of implementation, and maybe we could find a better name ? (-loc doesn't sound straightforward to me... Why not just opamfile or opam-file ?)
| in | ||
| OpamFile.OPAM.get_metadata_dir ~repos_roots opam | ||
| |> OpamStd.Option.map (fun d -> | ||
| OpamFilename.Op.(d//"opam") |
There was a problem hiding this comment.
Hm, does this work for pinned packages ? Can't the file be named differently?
There was a problem hiding this comment.
for pinned packages, it's stored in the overlay dir, in the file opam, and from repo, its the package dir with name opam.
There was a problem hiding this comment.
aah right, it'll never get back to the original srcdir, we always have a mirror, got it! 👍
maybe worth adding a comment ?
There was a problem hiding this comment.
It's always there, in the current run of opam (repo dir are tmp ones), yes. In fact, it's the code of OpamRepositoryState.get_root, that is not reachable from OpamPackageVar.
+1 for the comment
|
ok for me to rename it. |
|
I think |
bf6978a to
70bbe1b
Compare
opamfile-locopamfile
superseeds #4387