Skip to content

Fix pin kind consistency#4300

Merged
rjbou merged 3 commits intoocaml:masterfrom
rjbou:pin-consistency
Aug 5, 2020
Merged

Fix pin kind consistency#4300
rjbou merged 3 commits intoocaml:masterfrom
rjbou:pin-consistency

Conversation

@rjbou
Copy link
Copy Markdown
Collaborator

@rjbou rjbou commented Aug 4, 2020

  • With opam pin target, when opam file is not versioned and at root, vcs-pin the package instead of path-pin
  • With opam pin add nv target, take opam file even if not versioned

rjbou added 3 commits August 3, 2020 23:52
… instead of path-pin

With `opam pin target' only. If opam file is not at root, it is then a
subpath pinning, and it need to be path pinned.
@rjbou rjbou added this to the 2.1.0~alpha3 milestone Aug 4, 2020
@rjbou rjbou merged commit bd87702 into ocaml:master Aug 5, 2020
@rjbou
Copy link
Copy Markdown
Collaborator Author

rjbou commented Feb 4, 2021

The second point have an unattended side effect: if there is uncommitted local modification and you want to use an opam file at version hash in git history, it is not possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant