Allow CI to download archives from opam archive cache#4260
Merged
dra27 merged 9 commits intoocaml:masterfrom Jul 7, 2020
Merged
Allow CI to download archives from opam archive cache#4260dra27 merged 9 commits intoocaml:masterfrom
dra27 merged 9 commits intoocaml:masterfrom
Conversation
Unblocks CI when upstream tarballs aren't available.
MD5 sums were not checked in make -C src_ext cache-archives (so CI archives were not verified). Error reporting improved - it's now clear which tarballs were skipped on error. Code for downloading archives between lib-ext/lib-pkg and cache-archives merged.
89170c1 to
043e047
Compare
Member
Author
|
This PR is running in AppVeyor with a commit which ensures that the caches are blown away to test that mode too. |
This reverts commit 4869ee6.
Apparently GNU make 4 is more forgiving of poor syntax...
Member
Author
|
Hmm, 5th time lucky. The macOS Travis worker re-exposed an issue spotted in #3190, but which was incorrectly fixed by updating |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The URL for the opam cache in
src_ext/Makefilewas incorrect. This PR also extendsmake -C src_ext cache-archivesto use the opam cache if upstream tarballs aren't available (this was already the case formake lib-ext, but ifmake -C src_ext cache-archivesfails then the CI build fails...)