Skip to content

build cold bootstrap with OCaml 4.10 to fix gcc10 compilation#4234

Merged
avsm merged 1 commit intoocaml:masterfrom
avsm:cold-with-4.10
Jun 23, 2020
Merged

build cold bootstrap with OCaml 4.10 to fix gcc10 compilation#4234
avsm merged 1 commit intoocaml:masterfrom
avsm:cold-with-4.10

Conversation

@avsm
Copy link
Copy Markdown
Member

@avsm avsm commented Jun 16, 2020

This is because gcc10 defaults to -fcommon which causes
compatibility carnage. See ocaml/opam-repository#16583.

Reported by @MisterDA

@avsm
Copy link
Copy Markdown
Member Author

avsm commented Jun 16, 2020

@dra27 instead of the appveyor patch for unreleased flexdll, can we just use your fork in src_ext/Makefile directly?

@avsm avsm added this to the 2.1.0~alpha2 milestone Jun 16, 2020
@avsm avsm force-pushed the cold-with-4.10 branch from 3b8e072 to b51d07e Compare June 16, 2020 08:54
This is because gcc10 defaults to -fcommon which causes
compatibility carnage.  See ocaml/opam-repository#16583.

Reported by @MisterDA
@avsm avsm force-pushed the cold-with-4.10 branch from b51d07e to 1b0f4ba Compare June 16, 2020 09:03
@MisterDA
Copy link
Copy Markdown
Contributor

I have been using flexdll master ocaml/flexdll@bd636de in my
experiments. I don’t think that using @dra27 flexdll fork is
good. In a great scheme of things, a patch that is needed for
Opam’bootstrap should be included upstream — and @dra27 has write
access to the repo.
It’s possible to download a tar.gz of a specific commit of a repo from GitHub
(as a matter of fact, of any git ref):
https://github.com/alainfrisch/flexdll/archive/bd636def70d941674275b2f4b6c13a34ba23f9c9.tar.gz.
I don’t see a major downside to this approach. We’re not tracking
'master' since we’re pinning a revision.
For other dependencies of Opam, it could be even better since we would
not have to carry patches that already have been merged in master.

@avsm
Copy link
Copy Markdown
Member Author

avsm commented Jun 16, 2020

I'm referring to the Appveyor workaround - that should be reconciled with src_ext/Makefile. I'd prefer we didn't carry CI specific patches.

@dra27
Copy link
Copy Markdown
Member

dra27 commented Jun 23, 2020

Sorry for the lag. There will/should be a release of flexdll incorporating that patch prior to the release of OCaml 4.11 (as noted, it is now in flexdll master) which should make this moot. I agree with @MisterDA that pointing to my repo is a bad idea (especially as I may arbitrarily delete that branch when I next hoover my fork...)

@avsm avsm merged commit 2bf062d into ocaml:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants