Skip to content

Lib ocamlary#639

Merged
jonludlam merged 4 commits intoocaml:masterfrom
dbuenzli:lib-ocamlary
Mar 12, 2021
Merged

Lib ocamlary#639
jonludlam merged 4 commits intoocaml:masterfrom
dbuenzli:lib-ocamlary

Conversation

@dbuenzli
Copy link
Copy Markdown
Contributor

@dbuenzli dbuenzli commented Mar 12, 2021

On popular request, brings back the ocamlary library and installs it as odoc.ocamlary.

It seems that the source that was in the test/inactive/core inactive library had slightly diverged from the one in test/cases. I kept the former since a manual inspection seemed to indicate it had a few more test cases (also the former had the implementation) See commit comment.

Closes #630.

@dbuenzli
Copy link
Copy Markdown
Contributor Author

I kept the former since a manual inspection seemed to indicate

Mmh according to all this fancy CI that was maybe not a got idea… I'll try to converse to see how it goes.

We move it from test/cases to src/ocamlary and declare it
as a virtual library. The initial test case file becomes a
symlink to the library.
@dbuenzli
Copy link
Copy Markdown
Contributor Author

I don't understand this dune build @doc CI failure, if I do this on my machine:

ODOC_WARN_ERROR=true opam exec -- dune build @doc 

That exits with 0.

The main changes are suppression of generic references
and outdated markup constructs.
@dbuenzli
Copy link
Copy Markdown
Contributor Author

Ah ! It does error after a dune clean, good old make clean && make :-).

So I tweaked the ocamlary to compile without odoc warnings. See the commit for details.

@jonludlam jonludlam merged commit 50fcb86 into ocaml:master Mar 12, 2021
@dbuenzli dbuenzli deleted the lib-ocamlary branch March 13, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install the ocamlary

2 participants