HTML backend: refine specification rendering#615
Conversation
|
While doing this PR I realized the rendering by the default stylesheet of variants with a doc string is not very nice, I just want to stress that this is not a side effect of this PR. I don't think it's worth fixing before #614 is. |
Drup
left a comment
There was a problem hiding this comment.
I'm generally in favor of these changes, except for the copy-paste one. Your solution is, imho, not acceptable, but I'm pretty sure we can do better. The rest is good to go (as soon as the previous PRs are merged).
ae78979 to
db135b3
Compare
We simply use the `attr` pattern already present in the IR model. This also slightly tweaks some of the "kinds": * `extension` becomes `type extension` * `type-subst` becomes `type subst` * `external` becomes `value external` * `instance-variable` becomes `value instance-variable` Fixes part of ocaml#601.
db135b3 to
b716452
Compare
This has been removed.
I suggest we do that in a separate PR once #630 has been resolved. The PR has been rebased |
|
Thanks! |
This PR is built on top of #612, the relevant commits start at e7d6fd3
It does the following:
->so that browsers can be instructednot to break it.
type#601 adds several kinds forItem. We reuse theClass.ttype usually namedattr(sic). A few items get reclassified, mostly in a backward compatible way. See the commit message for details..docto.def-doc.odoc.csswith the changes.Tweakodoc.cssfor better c&p behaviour (closes Record field and variant case rendering breaks cut and paste #296).