Conversation
b760fae to
604abcb
Compare
|
This is best reviewed per commit. |
|
This looks pretty good to me! Do you intend to add the collapse in another PR ? I'm surprised there is no impact on the man/latex tests, but I guess that's good. :) |
If I don't manage to do it by the end of the week-end, I'll let that to someone else. |
That is the pair itself, not only its components.
Tags are mapped to description items classified by the tag name. We distinguish in a tag: the tag name, a value and a description. The tag name and value are separated by a space, properly classified and define the item term. The description defines the item definition.
N.B. that `.sel` class seems unused in the code base.
Cleaner than having their structure in Block.
c35e74c to
f6c8270
Compare
Why do you want to do that? The reason I’m asking is that I want to do some reviews, which requires me to know the reason behind your implementation. |
See the dicussion here #329. |
Thanks! |
|
LGTM! |
Drup
left a comment
There was a problem hiding this comment.
@jonludlam the CI failure is spurious, please fire away. :)
|
In it goes! |
|
Thanks, @dbuenzli ! |
This gets rids of
dlin HTML.In order to do so:
p)Btw. it seems the
ocp-indentfile is not consistent with whatocamlformatwants, e.g. w.r.t. identation. It's quite annoying.