Skip to content

Handle 4.08 module and type substitutions#381

Merged
trefis merged 4 commits intoocaml:masterfrom
jonludlam:408-substitutions
Sep 11, 2019
Merged

Handle 4.08 module and type substitutions#381
trefis merged 4 commits intoocaml:masterfrom
jonludlam:408-substitutions

Conversation

@jonludlam
Copy link
Copy Markdown
Member

This PR will render the new syntactic elements as written in the mli files. This should fix #350 as it qualifies as 'minimal support'. We might want to consider removing the substituted modules and types entirely, depending on how these features end up being used.

This is a 4.08 only feature

Signed-off-by: Jon Ludlam <jon@recoil.org>
Signed-off-by: Jon Ludlam <jon@recoil.org>
Copy link
Copy Markdown
Contributor

@trefis trefis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Signed-off-by: Jon Ludlam <jon@recoil.org>
Signed-off-by: Jon Ludlam <jon@recoil.org>
@trefis trefis merged commit c08dc76 into ocaml:master Sep 11, 2019
@aantron
Copy link
Copy Markdown
Contributor

aantron commented Sep 12, 2019

Thanks @jonludlam and @trefis. Please let me know if we need a speedy release. Otherwise, the next release should be around 1 October.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support ocaml 4.08 features

3 participants