Merged
Conversation
Restrictions on the target are moved to semantics.ml
References are represented as strings in Parser.Ast
This completely remove references from Parser.Ast
aantron
reviewed
Jun 13, 2019
Contributor
aantron
left a comment
There was a problem hiding this comment.
Ok, having seen this change, it actually looks quite reasonable, and I think we can merge this.
Apart from the comments, there are also some CI failures on older versions of OCaml.
Let me know if you'd like #351 reopened, or submit a new PR for how you want to expose this AST.
I still would like to avoid committing to the stability of Model.Comment, Parser.Ast, or the parser, but we can reach out when making any breaking changes.
Collaborator
Author
|
Thanks for your review ! I cleaned the code but did not manage to fix the CI with 4.08 yet. |
Contributor
Collaborator
Author
|
Thanks for merging ! |
This was referenced Jun 18, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
As I explained in #355,
Model.Commentis a bit hard to obtain and understand and too strict and lossy on the input.Some of this issues could be solved by changing
Model.Commentwith a bit of work. But I think that in the future, this will make similar issues harder to solve as Odoc codebase and language change.This PR simplifies
Parser.Astto make it closer to the concrete syntax and simpler by delaying some parsing tosemantics.ml:Raw_markuptargets can be any string or none.Spaceelement is generated)This PR also removes some uses of
Modeltypes, as @lpw25 suggested, but not all yet.This PR is supposed to follow #351 but if this approach is definitively rejected, it should be a good first step at improving
Model.Comment.What do you think?
Thanks!