Conversation
Resolves #174. See also: #153 (comment)
Contributor
I think this needs an |
Contributor
Author
|
Ok, it now has the same options as The only problem is that the code fails if the output directory doesn't exist. I'll undo that next, but I want to check whether the output and command line are otherwise reasonable. |
Contributor
|
Thanks ! Looks to me exactly what is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR:
The command has no options.I assume this output is suitable for consumption. cc @dbuenzli, @rgrinberg (though I will/can make a PR to Dune to use this).
Resolves #174.
See also #153 (comment).