Merged
Conversation
When executing [let st = st.next.[...]], the initial [st] is still live, so the compiler cannot reuse the register for the new value of [st] and a move instruction will have to be performed. As a hack, we add another parameter to the loop functions that contains the same value as the initial [st] and can be used afterwards. We still have a move to set this parameter, but it is no longer on the critical path.
We replace [let st = st.next.[...]] by [let st = st.[...]]. This removes one memory access on the critical path, making it twice shorter. But we now have to use [Obj.magic] to get information about the current state...
Now that the critical path is much shorter, the bottleneck becomes the number of instructions executed by loop iteration: bound checks are no longer "for free".
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A very nice performance improvement