Make Ephemeron compatible with infix pointers.#9742
Merged
xavierleroy merged 2 commits intoocaml:trunkfrom Jul 27, 2020
Merged
Conversation
Contributor
Author
|
I am not completely sure I did not miss any patch, perhaps, @bobot, you could check a bit more. |
Contributor
Author
|
Since this is a bugfix, this could be back ported to 4.11. That said, given that this bug exists for a long time for weak pointers and nobody was really annoyed, this may not be necessary. |
2f9ec15 to
02f6998
Compare
Contributor
|
@bobot, @damiendoligez : this is a bug fix for an area of the run-time system that you are responsible for. Please review. |
Contributor
|
@bobot are you happy with the revised PR? @damiendoligez would you care to comment? |
Contributor
|
Thank you gentlemen, I'll merge now. It's too late for a backport to 4.11, this will wait until 4.12. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #9485 and #7810.
Cc @bobot, @damiendoligez.