#5428: import comment on flatten_fields#9567
Merged
Octachron merged 1 commit intoocaml:trunkfrom May 18, 2020
Merged
Conversation
4491702 to
aa4ca4b
Compare
garrigue
approved these changes
May 16, 2020
Contributor
garrigue
left a comment
There was a problem hiding this comment.
I'm fine with this comment, hoping this doesn't shock people.
aa4ca4b to
9fe4b96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue #5428 reads more like a comment on the semantic of
flatten_fields. I propose to move this comment to the code source rather than the issue tracker.cc @garrigue .
Close #5428