Fix "x86 asm: handle unit names with special characters" test for bsd#9473
Merged
nojb merged 1 commit intoocaml:trunkfrom Apr 19, 2020
Merged
Fix "x86 asm: handle unit names with special characters" test for bsd#9473nojb merged 1 commit intoocaml:trunkfrom
nojb merged 1 commit intoocaml:trunkfrom
Conversation
Contributor
Author
|
Precheck passed, so planning to merge as soon as AppVeyor finishes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test introduced in #9465 fails on openbsd/freebsd in INRIA's CI. It looks like
gcchas trouble with directories containing some of the special characters in that test. Directories containing the filename (thus the special characters) are created byocamltest.After a couple of hours of debugging I did not manage to find a good fix, so I propose to downscale our ambitions for the test and simply test digits and dashes, which was the reason of the original bug fix.