Conversation
Regression from ocaml#9283. Fixes ocaml#9455
|
It sounds like it would be a good idea to have test? |
|
I'm just about to push it! |
|
That test definitely fails on |
gasche
left a comment
There was a problem hiding this comment.
Nice catch!
Some minor questions/remarks:
- there is another use of
falseinuse_output, is that one correct? - could we maybe use a labelled argument? (non-labelled boolean are a code smell as their call-sites are unreadable)
- I believe that
wrap_modwas the right spelling, notwrap_mode, as I think "mod" refers to "module" here.
|
(But maybe |
|
Actually, the typo was the other way around - @diml mistyped I agree that a labelled argument or renaming would be better, but that code was fine for 8 years prior to being poked for a new feature - and the toplevel is getting a lot of attention elsewhere at the moment, anyway. The use of |
|
Yes, our comments on wrap_mod agree. (Although I see why it's confusing that I'm commenting on the diff from the other PR). Personally I would prefer to improve the code now that there was a bug, instead of waiting for the next bug. I will push a labeling commit. |
|
I can confirm that a30e621 fixes the various topfind compilation issues I saw. |
|
@dra27 I will let you decide if/when to merge given that I was the last to push a commit. |
|
PR looks good to me too! |
|
Thanks @diml - let's do it! |
Regression from #9283. Fixes #9455.
This is an absolute show-stopper for 4.11!