Fix configure: Define the CAML_SAFE_STRING variable when force-safe-string is on#9117
Merged
dra27 merged 4 commits intoocaml:4.10from Nov 14, 2019
Merged
Fix configure: Define the CAML_SAFE_STRING variable when force-safe-string is on#9117dra27 merged 4 commits intoocaml:4.10from
dra27 merged 4 commits intoocaml:4.10from
Conversation
Member
|
Thanks, @kit-ty-kate and good spot for suspicious passes in the CI! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing all packages in opam with OCaml 4.10 I was surprised to see that some old versions of some packages that I expected to fail (due to using the wrong C type for the string type –
char*instead ofconst char*) did not fail.This PR fixes the mistake I made in #1859, where I forgot to move the definition of
CAML_SAFE_STRINGto the other side of the if in the configure script.This is a PR for the
4.10branch but this should also be ported totrunk. Let me know if I should've done this the other way around.