stdlib/Makefile: use list of modules from StdlibModules#8994
stdlib/Makefile: use list of modules from StdlibModules#8994nojb merged 2 commits intoocaml:trunkfrom
Conversation
|
Doesn't the manual depend on that list being in alphabetical order? (see note in |
Good question(s). I haven't checked but I would surprised if |
|
I hope it's that the HACKING documentation is out-of-date, as it's an obvious code-quality improvement! |
|
As far as I remember, the manual should be totally independent from the module order in StdlibModules. In particular, the ordering of the modules in the "Standard library" chapter is hard-coded in |
|
I pushed a commit updating |
|
I’d already checked that the before and after lists were equivalent so if @Octachron is happy from the docs perspective, I’d say go for it! |
|
OK, planning to merge once CI passes. |
|
(@dra27 would you use the explicit "approve" mechanism?) |
dra27
left a comment
There was a problem hiding this comment.
I was going to let Florian do that, but here is my magic seal 🙂
Octachron
left a comment
There was a problem hiding this comment.
I can confirm that the manual is not affected by those changes.
This is a tweak in
stdlib/Makefileto re-use the list of modules fromstdlib/StdlibModules, so that there is one less spot that needs to be updated when adding a new stdlib module.On the other hand, this means that the modules in
stdlib/StdlibModulesneed to be listed in dependency order.