Skip to content

Test make world on Inria CI#8845

Merged
dra27 merged 2 commits intoocaml:trunkfrom
dra27:old-school
Jul 31, 2019
Merged

Test make world on Inria CI#8845
dra27 merged 2 commits intoocaml:trunkfrom
dra27:old-school

Conversation

@dra27
Copy link
Copy Markdown
Member

@dra27 dra27 commented Jul 30, 2019

Apropos a mix of @xavierleroy's #8837 (comment) and #8837 (comment), this PR adds a check to Inria's extra-checks script to ensure that make world definitely works.

I don't think this is worth running on every PR, though.

@dra27
Copy link
Copy Markdown
Member Author

dra27 commented Jul 30, 2019 •
edited
Loading

(AppVeyor and Travis cancelled, as they can't be affected)

@gasche
Copy link
Copy Markdown
Member

gasche commented Jul 30, 2019

Note that we already have the Travis MIN_BUILD=1 build that compiles with --disable-shared, --disable-native-compiler, so it would definitely catch any unsanitary reliance on .opt tools.

@dra27
Copy link
Copy Markdown
Member Author

dra27 commented Jul 30, 2019

Yes, except the MIN_BUILD is really minimal - it doesn’t build ocamldoc at all!

xavierleroy
xavierleroy approved these changes Jul 31, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@xavierleroy xavierleroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

It's largely superstition, but: I would prefer to run the "check-typo" test and this "old school build" test at the beginning of extra-checks, before the fancy sanitizer things. I have this vague idea that simpler tests run first, then more complicated ones -- even though it makes no difference when all the tests pass!

@dra27
Copy link
Copy Markdown
Member Author

dra27 commented Jul 31, 2019

@xavierleroy - no problem, I've moved them up the script. I'll merge once Travis runs the two relevant tests and then keep an eye on Jenkins.

@xavierleroy
Copy link
Copy Markdown
Contributor

xavierleroy commented Jul 31, 2019

Excellent, thanks!

@dra27 dra27 merged commit d689f33 into ocaml:trunk Jul 31, 2019
@dra27 dra27 deleted the old-school branch August 4, 2020 13:57
@dra27 dra27 mentioned this pull request Aug 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xavierleroy xavierleroy xavierleroy approved these changes

Assignees

No one assigned

Labels

no-change-entry-needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dra27 @gasche @xavierleroy